search

ipfs-inactive / kubernetes-ipfs

[ARCHIVED] kubernetes-ipfs
60 stars 25 forks source link

Epic merge: ipfs-cluster-dev and DSL features #26

Closed ZenGround0 closed 7 years ago

ZenGround0 commented 7 years ago

@hsanjuan @dgrisham This is the merge of cluster-dev and the two branches I have going for DSL features. Those branches each have their own well documented PRs #23 and #25 . Weak spots include testing integration, I have yet to get main_test.go running the tests for 3 of the 4 mods of #25 and the tests for these mods really require manual inspection of files right now, and validation. I have only added validation for the fourth modification of #25 and perhaps it will be more user-friendly to do some validation involving the for and append_on structures and maybe even with command strings. The regexes I use work with decent generality but perhaps we can do better. The environment's inclusion of arrays is a bit sloppy (every run that uses the array appends the whole thing to env and never takes it off), so I am interested in your suggestions for any improvements here too.

ZenGround0 commented 7 years ago

@hsanjuan Ok I have addressed this feedback. Get back to me with any other thoughts.

ZenGround0 commented 7 years ago

@hsanjuan These new changes fix up the sloppy inclusion of arrays mentioned in the environment along with the reordering of selection so that it happens every iteration allowing iterations to proceed on random nodes.

hsanjuan commented 7 years ago

You will need to rebase probably before merge, if @dgrisham things get merged first.

ZenGround0 commented 7 years ago

Cool, tests run successfully with these changes. I am ready to rebase once the parameters PR is merged in.