ipfs-inactive / website

This repo has been replaced by https://github.com/ipfs/ipfs-website/
https://github.com/ipfs/ipfs-website/
MIT License
183 stars 128 forks source link

"Get IPFS Desktop" button on ipfs.io returns a 404 #377

Closed chrishobcroft closed 4 years ago

chrishobcroft commented 4 years ago

Summary of issue

The "Get IPFS Desktop" button, in the "Install" section of IPFS Homepage, links to a dead link, and returns a 404.

Steps to reproduce

  1. Load up IPFS Homepage in a browser

Screenshot from 2020-05-17 16-54-00

  1. Click "Install"

Screenshot from 2020-05-17 16-54-07

  1. Click "Get IPFS Desktop"

Screenshot from 2020-05-17 16-54-07

  1. Unexpected Behaviour: see @github's cute Star Wars-themed 404.

Screenshot from 2020-05-17 17-04-15

I thought IPFS was all about getting rid of the 404 errors? ;)

Expected behaviour

At step 4, I expected it to show:

https://github.com/ipfs-shipyard/ipfs-desktop

Instead it showed:

https://github.com/ipfs-shipyard/ipfs-desktopfs

Seems like a typo with the extra fs. Too many "fs" can make a mess :)

welcome[bot] commented 4 years ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

chrishobcroft commented 4 years ago

Here is pull request for fixing this: https://github.com/ipfs/website/pull/378

Blame @jessicaschilling for committing this broken link here.

But it's OK Jessica, typos are easy to do.

I'm relieved that it only took 8 days to test, find and fix this :)

Donations accepted in ETH or any ERC-20 token at chrishobcroft.eth :)

jessicaschilling commented 4 years ago

Closed by #378.

It’s a bit difficult to discern whether the sarcasm is gentle or biting, but in any case, the fix is appreciated.

(FWIW, been faced with a family emergency the last two weeks, though not wishing to make excuses.)

chrishobcroft commented 4 years ago

It's definitely gentle, with the proliferation of :) symbols.

Happy to help, I love IPFS :) and thank you for merging it, I can now install IPFS Desktop more easily on my newly installed Ubuntu 20.04 LTS :)

Nice to meet you @jessicaschilling and I hope the family emergency is resolved. All the very best!