This is a bigger update because libp2p removed NetworkBehaviourEventProcess, which means that all state needs to move out of the Behaviour and into the place that calls poll.
As I was touching this code anyway, I removed the mutex-based swarm access and fully encapsulated the Swarm in its own task, making all external requests asynchronous (and also 'static, i.e. owned data, so that they can travel through channels).
The result is that some tests broke because they had previously relied upon scheduling artifacts caused by the mutex approach.
This is a bigger update because libp2p removed NetworkBehaviourEventProcess, which means that all state needs to move out of the Behaviour and into the place that calls
poll. As I was touching this code anyway, I removed the mutex-based swarm access and fully encapsulated the Swarm in its own task, making all external requests asynchronous (and also'static, i.e. owned data, so that they can travel through channels). The result is that some tests broke because they had previously relied upon scheduling artifacts caused by the mutex approach.