ipfs-rust / ipfs-embed

A small embeddable ipfs implementation
352 stars 48 forks source link

New storage engine #17

Closed dvc94ch closed 3 years ago

vmx commented 3 years ago

I had a very quick look only. From that quick look it wasn't clear to me what the id is really about. is it an internal thing (like a monotonically increasing sequence number) or something the user specifies (it seems so from the README). Some enums/structs use u64 values, which seem to map to those IDs. Perhaps it would make sense to define a type alias/wrapper type to make it clearer that those are IDs.

Other than that it looks like a clean storage system.