ipfs-rust / ipfs-embed

A small embeddable ipfs implementation
348 stars 49 forks source link

Adding wrong addresses to DHT #22

Closed semtexzv closed 3 years ago

semtexzv commented 3 years ago

I believe there is a bug in in the handling of IdentifyEvent

The field observed_addr in this field refers to local node, and not the peer. https://docs.rs/libp2p/0.29.0/libp2p/identify/enum.IdentifyEvent.html The code in https://github.com/ipfs-rust/ipfs-embed/blob/master/net/src/behaviour.rs#L159 is adding this address as the address of peer to kademlia.

semtexzv commented 3 years ago

Scratch that, found it .