search

ipfs-shipyard / gomobile-ipfs

IPFS and libp2p on Mobile, with Gomobile
Other
324 stars 63 forks source link

chore: Top-level Makefile #142

Closed jefft0 closed 2 years ago

jefft0 commented 2 years ago

This pull request has 3 commits. The first commit fixes the build of the iOS Example app: Unwrap the result of sendToDict which is now optional. Update the IPHONEOS_DEPLOYMENT_TARGET to 13.

The second commit simply moves files from the packages folder to the top level as-is. We do this so that the next commit will show the changes to the Makefile. Also, we move deps.mod to the go folder and we delete packages/go.mod.

The third commit updates the Makefile with the correct paths for GO_DIR, etc. We also use cd $(GO_DIR) && before every go command, which allows us to use a single go.mod file in the go folder. In the go.mod file we merge entries from packages/go.mod (now deleted). Finally, in Android, iOS and workflow scripts we update paths with /packages to the top folder.

jefft0 commented 2 years ago

Hello @aeddi and @gfanton . This will become the pull request to move the Makefile from packages to the top level. Before I move it, I wanted the build for the iOS Example app to work (so that I can check if it still builds after moving the Makefile). Previously, the Xcode project linked to GomobileIPFS.framework, but it seems like the Makefile doesn't build this. Should it? (In this pull request I changed the Example app to compile the Swift files for GomobileIPFS directly.)

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: