ipfs-shipyard / ignite-metrics

Metrics consent and client provider library for ipfs/ipfs-gui team (i.e. IPFS Ignite). See ipfs/ipfs-gui#129 for more details
Other
4 stars 3 forks source link

feat: switch to opt-out metrics #2

Closed SgtPooki closed 1 year ago

SgtPooki commented 1 year ago

Note that until https://github.com/ipfs/ipfs-gui/issues/125, https://github.com/ipfs/ipfs-gui/issues/130, and https://discuss.ipfs.tech/t/ipfs-gui-metrics-changes-in-progress/15695 have been available to the community for feedback for enough time (at least two weeks: ETA Jan 20th), we will continue with the implementation we currently have in public-gateway-checker:

welcome[bot] commented 1 year ago

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

Finally, remember to use https://discuss.ipfs.io if you just need general support.

SgtPooki commented 1 year ago

Send a metric when users disable necessary metrics. This would give us a signal about the number of users we have that prefer zero telemetry collection

This would be essentially the only datapoint we have for users that don't want telemetry collected for them, other than any other 'session' or 'view' metrics that are sent prior to them opting-out.

thoughts? @lidel @whizzzkid @tinytb

lidel commented 1 year ago

I am afraid this is still sending a telemetry: HTTP request will be reporting someone's IP and user-agent. Lying like that may be problematic from a legal standpoint: IP is considered private information in some jurisdictions.

Opt-out should be opt-out. When user opts-out,send "opt-out" event once, and never send anything again. You can infer what % of users opted-out from metrics by comparing the rolling averages (e.g. motnhly) of first-install vs opt-out events or something :)

SgtPooki commented 1 year ago

When user opts-out,send "opt-out" event once, and never send anything again.

This is exactly what I'm saying