ipfs-shipyard / ipfs-css

The single-purpose css class names and font-face config to IPFS up your UI.
MIT License
24 stars 19 forks source link

Icon, font, color improvements #40

Closed jessicaschilling closed 4 years ago

jessicaschilling commented 4 years ago

Proposing this as major release for ipfs-css; fixes a number of outstanding issues.

Closes https://github.com/ipfs-shipyard/ipfs-css/issues/21

Closes #28

Unblocks (but doesn't close) https://github.com/ipfs-shipyard/ipfs-webui/issues/1379

Augments (already-closed) #37

Closes #29 - but with question

Closes #10

Miscellany

jessicaschilling commented 4 years ago

@olizilla, @hacdias and/or @lidel ... would greatly appreciate your eyes on this one.

Thanks all!

olizilla commented 4 years ago

not got a full review, just wanted to clarify:

It looks as though in the past we've simply duplicated the entire contents of the Montserrat and Inter repos rather than only bring in the finished font files themselves; have done that in this PR, but I'm wondering why.

The fonts were included as a git subtree... (https://www.atlassian.com/git/tutorials/git-subtree) for maximum traceability and history preservation, which is nice. We dont have to do that, but it would be nice to continue if it doesn't cause issue.

jessicaschilling commented 4 years ago

@olizilla Thanks for the subtree info -- set that back up again.

jessicaschilling commented 4 years ago

@lidel - good call on the major version. Will do.

As for the extraneous files:

Do you mind cleaning and rebuilding and seeing what you get?