Closed jessicaschilling closed 4 years ago
@olizilla, @hacdias and/or @lidel ... would greatly appreciate your eyes on this one.
Thanks all!
not got a full review, just wanted to clarify:
It looks as though in the past we've simply duplicated the entire contents of the Montserrat and Inter repos rather than only bring in the finished font files themselves; have done that in this PR, but I'm wondering why.
The fonts were included as a git subtree... (https://www.atlassian.com/git/tutorials/git-subtree) for maximum traceability and history preservation, which is nice. We dont have to do that, but it would be nice to continue if it doesn't cause issue.
@olizilla Thanks for the subtree info -- set that back up again.
@lidel - good call on the major version. Will do.
As for the extraneous files:
Inter-UI
files shouldn't be there; that's the old name for the Inter font and I'm worrying there might be something screwy happening subtree-wise.Montserrat-Black
and Montserrat-Thin
variants shouldn't be there either; they're explicitly being excluded in package.json (again, worried about subtree)Montserrat-ExtraBold
, Montserrat-Medium
and Montserrat-ExtraLight
variants are supposed to be there so that we support the full 300-800 weight range for both fonts.Montserrat-LICENSE.txt
is supposed to be there.Do you mind cleaning and rebuilding and seeing what you get?
Proposing this as major release for ipfs-css; fixes a number of outstanding issues.
Closes https://github.com/ipfs-shipyard/ipfs-css/issues/21
Closes #28
Unblocks (but doesn't close) https://github.com/ipfs-shipyard/ipfs-webui/issues/1379
teal
value#3e9096
with#378085
for accessibility as proposed hereAugments (already-closed) #37
vars.scss
andtheme.scss
fromtheme.json
vars.scss
andtheme.scss
up to top level of directory structure, so it's in the same place asipfs.css
Closes #29 - but with question
interui
,inter ui
,inter ui
references to justinter
due to 2019 name change@font-face
support for the following:ExtraLight
300,ExtraLightItalic
300,SemiBold
600,SemiBoldItalic
600,ExtraBold
800,ExtraBoldItalic
800Medium
500,MediumItalic
500,ExtraBold
800,ExtraBoldItalic
800Thin
,ThinItalic
,ExtraLight
,ExtraLightItalic
,Black
,BlackItalic
Black
,BlackItalic
,Light
,LightItalic
,InterDsplay*
,Inter-Thin*
Closes #10
@font-face
support for .woff and .eot fonts in Montserrat@font-face
support for .woff and .otf fonts in InterMiscellany