Redefining `.link` changes the specificity and causes suprises - Githubissues

ipfs-shipyard / ipfs-css

The single-purpose css class names and font-face config to IPFS up your UI.

MIT License

24 stars 19 forks source link

Redefining `.link` changes the specificity and causes suprises #48

Open olizilla opened 3 years ago

olizilla commented 3 years ago

Colours of things in ipld explorer have been overriden where ever they are also a .link. It's an unfortunate inclusion in tachyons, but we've used it to strip underlines off things in a few places. When it got overridden in ipfs-css it's specificity got a boost and it now overrides colours in a few places

ipld explorer cid info panel... the 12 in the legend should be orange to match the 12 in the multihash

Screenshot 2021-04-23 at 14 42 59

ipld explorer graph crumb... the text colour should match the underline colour

Screenshot 2021-04-23 at 15 12 26

I suggest we remove .link from ipfs-css

lidel commented 3 years ago

Sounds sensible, but this will be a breaking change requiring major release + additional work to inspect every screen in webui and other places ipfs-css is used 😬