ipfs-shipyard / ipfs-deploy

Zero-Config CLI to Deploy Static Websites to IPFS
Other
1.16k stars 123 forks source link

fix: adding --site-domain to --help #135

Closed DavidBurela closed 4 years ago

DavidBurela commented 4 years ago

When uploading to a service that uses the tag as metadata to label the pin, it defaults to using the full path of the folder e.g. /mnt/c/source/...

What This PR adds information about --site-domain parameter that can be used to add a friendly name for the pin.

image

Testing image

image image image

yieme commented 4 years ago

It seems this can already be accomplished using: --siteDomain "Friendly Name" Perhaps the current option needs to be documented in --help

DavidBurela commented 4 years ago

Hmmm. I looked in the code, saw sitedomain, but couldn't get it to work when I passed it in. I'll investigate.

If so, I'll change PR to update --help

yieme commented 4 years ago

for what it's worth --siteDomain is working for me, at least to Pinata

DavidBurela commented 4 years ago

@yieme i found out why it didn't work when I was investigating the code yesterday. I was using --sitedomain, it was case sensitive.

I have removed --friendly-name and instead added information in --help to surface this

hacdias commented 4 years ago

Thanks @DavidBurela!