search

ipfs-shipyard / ipfs-deploy

Zero-Config CLI to Deploy Static Websites to IPFS
Other
1.16k stars 122 forks source link

fix: pinata deploy error handling and 429 retries #192

Closed mikeshultz closed 3 years ago

mikeshultz commented 3 years ago

This PR refactors the Pinata module a bit to use async/await for cleaner error bubbling and adds retries for 429 responses (rate limiting).

Let me know if you have any feedback.

Related: https://github.com/OriginProtocol/dshop/issues/812

mikeshultz commented 3 years ago

Just noticed the tests. Will make sure these pass today and leave this PR up for any feedback in the mean time.

mikeshultz commented 3 years ago

Tests pass now, but Travis sure is taking its sweet time.

micahalcorn commented 3 years ago

@hacdias any chance that we could get this merged or some feedback? Thanks!

hacdias commented 3 years ago

@mikeshultz thanks for this!

@mikeshultz @micahalcorn very sorry this took a while! I didn't receive any notifications even though I was mentioned, which is quite odd [or I completely missed it]. I will check the settings.