search

ipfs-shipyard / ipfs-deploy

Zero-Config CLI to Deploy Static Websites to IPFS
Other
1.16k stars 122 forks source link

Infura pin doesn't add "hidden" files. #193

Closed kevincox closed 3 years ago

kevincox commented 3 years ago

See the following log. The Pinata hash correctly has the hidden files while the Infura hash does not.

$ npx ipfs-deploy -p infura -p pinata results/www
npm WARN exec The following package was not found and will be installed: ipfs-deploy
npm WARN deprecated promisify-es6@1.0.3: Unmaintained
npm WARN deprecated axios@0.19.2: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
- 📦  Calculating size of results/www…
✔ 🚚  Directory results/www weighs 171.1 KiB.
- 📠  Uploading and pinning to Infura…
✔ 📌  Added and pinned to Infura with hash:
ℹ 🔗  QmXtD3PR7HGRsRTwzxkqgoJ49rB1rAbMuDPnPncQLvygix (​https://ipfs.infura.io/ipfs/QmXtD3PR7HGRsRTwzxkqgoJ49rB1rAbMuDPnPncQLvygix/​)
- 📠  Uploading and pinning to Pinata…
✔ 📌  Added and pinned to Pinata with hash:
ℹ 🔗  QmUat2v238CwJe6AADamqdzmEKg59AM7Qxb9CLrcXEor2T (​https://gateway.pinata.cloud/ipfs/QmUat2v238CwJe6AADamqdzmEKg59AM7Qxb9CLrcXEor2T/​)
✖ ≠  Found inconsistency in pinned hashes:
  ┌──────────────────────────────────────────────────────────────────────────┐
  │                                                                          │
  │ {                                                                        │
  │    "infura": "QmXtD3PR7HGRsRTwzxkqgoJ49rB1rAbMuDPnPncQLvygix",           │
  │    "pinata": "QmUat2v238CwJe6AADamqdzmEKg59AM7Qxb9CLrcXEor2T"            │
  │ }                                                                        │
  │                                                                          │
  └──────────────────────────────────────────────────────────────────────────┘
hacdias commented 3 years ago

Thanks for the report. I think this is fixable. However, we need to make it clear on the README!

hacdias commented 3 years ago

There's two "big" options in my view:

kevincox commented 3 years ago

As I said on #210 either option will confuse some users but the correct thing to do is confuse them in the safest way (or force a choice I guess). People are more likely to notice that their hidden files are missing than notice that they are uploading their keys so by default we should skip their hidden files.

Also their choice is a breaking change, so may as well do the safe thing.