search

ipfs-shipyard / ipfs-deploy

Zero-Config CLI to Deploy Static Websites to IPFS
Other
1.16k stars 122 forks source link

breaking: consistently add hidden files to IPFS #210

Closed hacdias closed 3 years ago

hacdias commented 3 years ago

This is both a fix and a new feature. It fixes #193 by consistently adding (or not) hidden files to all IPFS pinning services. By default, they are not added. I introduced a new flag -H, --hidden to include dot files.

It is also a breaking change in terms of API. So v10.0.0 needs to be released after merging this.

License: MIT Signed-off-by: Henrique Dias hacdias@gmail.com

hacdias commented 3 years ago

@kevincox what do you think about this solution?

kevincox commented 3 years ago

I think this is good. While ignoring files by default may be surprising at least it is surprising in a safe way. People are more likely to notice that their hidden files are missing than notice that they are uploading their keys.

kevincox commented 3 years ago

Also worth noting that any default that we pick is a breaking change.