search

ipfs-shipyard / ipfs-deploy

Zero-Config CLI to Deploy Static Websites to IPFS
Other
1.16k stars 123 forks source link

refactor: creates more modularity #76

Closed hacdias closed 5 years ago

hacdias commented 5 years ago

Ref.: #75.

It makes it simpler to add more pinning or dnslink services.

License: MIT Signed-off-by: Henrique Dias hacdias@gmail.com

hacdias commented 5 years ago

/cc @agentofuser

agentofuser commented 5 years ago

Oh wow, this looks great, @hacdias! Thank you for taking the time to tidy things up.

This is the first larger PR I get, and now I really wish I had a test suite 😅

Anyway, I'm sure you've done some manual testing, and I prefer to make later corrections or rollbacks easier than to add roadblocks to merging.

I'll do some testing on my side too before releasing.

Btw I've been very busy with keykapp and haven't been able to give ipfs-deploy the attention it deserves, so if you would like to be able to make releases I'll be more than glad to add you as a collaborator.

Thanks again for the contribution!

hacdias commented 5 years ago

Oh wow, this looks great, @hacdias! Thank you for taking the time to tidy things up.

No problem! Still have a few improvements and simplifications to make! :O

This is the first larger PR I get, and now I really wish I had a test suite 😅

I think I can perhaps work on some tests after the simplifications/improvements I have in mind!

Anyway, I'm sure you've done some manual testing, and I prefer to make later corrections or rollbacks easier than to add roadblocks to merging.

I did! I also agree with you!

I'll do some testing on my side too before releasing.

👍

Btw I've been very busy with keykapp and haven't been able to give ipfs-deploy the attention it deserves, so if you would like to be able to make releases I'll be more than glad to add you as a collaborator.

Can do! Thanks 😃

Thanks again for the contribution!

NP!