search

ipfs-shipyard / ipfs-dns-deploy

A circleci friendly Docker image for pinning things to cluster and updating dns
https://hub.docker.com/r/ipfs/ipfs-dns-deploy/tags
MIT License
38 stars 4 forks source link

Publish debug docker image #9

Open olizilla opened 4 years ago

olizilla commented 4 years ago

as suggested by @hsanjuan , add set -x to the pin-to-cluster.sh script and publish as a docker image tagged asdebug. CI configs can then selectively switch to it by updating the docker image tag.

olizilla commented 4 years ago

debug image pushed to olizilla/ipfs-dns-deploy:debug https://registry.hub.docker.com/layers/olizilla/ipfs-dns-deploy/debug/images/sha256-f501b45142b540c23e5f8c2b804e9eb96d6e9203ab39248d7e70b903ec6b3720?context=explore

from branch debug https://github.com/ipfs-shipyard/ipfs-dns-deploy/compare/debug

hsanjuan commented 4 years ago

@olizilla can we add --debug to ipfs-cluster-ctl as well : ipfs-cluster-ctl --debug...

hsanjuan commented 4 years ago

Did it myself

olizilla commented 4 years ago

Does --debug changes the output of ipfs-cluster-ctl in the happy path? If it does then it can't be used in CI workflows that expect the output of pin-to-cluster.sh to be just the CID that is then used for dnslink updating.

thattommyhall commented 4 years ago

Is it worth echo-ing the result of ipfs-cluster-ctl status $root_cid" to stderr too?

olizilla commented 4 years ago

@thattommyhall my mental model of bash, sub-shells and output streams is not good; can pin-to-cluster.sh log to stderr without disrupting the assumption that the result will be just the cid if called sub-shell style"

cid=$(pin_to_cluster.sh args go here)
hsanjuan commented 4 years ago

@olizilla I think this can be closed?