ipfs-shipyard / ipfs-github-action

Pin your site to IPFS from a GitHub Action
68 stars 7 forks source link

Fix interpolation of env vars when calling docker action with input args #2

Closed olizilla closed 4 years ago

olizilla commented 4 years ago

This seems like a foot gun that is gonna waste a lot of folks time. If you try an pass an input argument to a docker action as an input, env vars do not get interpolated, so you can't pass a path as $GITHUB_WORKSPACE/path/to/thing without manually re-interpolating it in the entrypoint.sh... it's described in the docs, but it's not obvious, and seems like exactly what you'd want to do.

See: https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#entrypoint