search

ipfs-shipyard / ipfs-github-action

Pin your site to IPFS from a GitHub Action
68 stars 7 forks source link

IPNS support #4

Open lidel opened 4 years ago

lidel commented 4 years ago

Would be really useful to update IPNS record in addition to updating DNSLink. Or instead.

This requires figuring out how key management should work in CI contexts. Would entire publishing key be a secret defined in settings of a GitHub repo and passed to the action?

@olizilla any prior art or thoughts about his?

olizilla commented 4 years ago

This action does the work by sending the content to a remote ipfs-cluster. This was deliberate so we offload the IPFS work to a long running node. Setting a DNSLink or updating an IPNS record could be seperate action / entrypoint. Ideally you'd just do it by exposing a pinning api on a remote node behind basic auth or similar. 💁‍♂️

olizilla commented 4 years ago

of course by pinning i mean ipnsing.

olizilla commented 4 years ago

For completeness, it's worth noting that this action does not handle setting dnslinks, but it does provide the CID as an output, so you can pass it to dnslink or IPNS setting step like https://github.com/filecoin-project/specs/blob/71f37208a1f4f56b33ea307d7cbdb4b06996b115/.github/workflows/main.yml#L38-L44

lidel commented 4 years ago

Ack, makes sense :+1:

Should we keep this issue open until we have an established way of doing IPNS updates on CI? Eg. a separate action. (Then we would update README in this repo pointing at the thing)