search

ipfs-shipyard / ipfs-share-files

Share files via IPFS
https://share.ipfs.io
MIT License
145 stars 29 forks source link

Visually clarify view-new-window vs download functionality #105

Closed jessicaschilling closed 3 years ago

jessicaschilling commented 3 years ago

Per @autonome note in Jan 2021 hack week:

Be able to view (mime detect) instead of download, with something in URL that indicates that for share links.

This isn't looking like it'll make the time crunch for the week, so capturing in an issue for later inclusion. Community PRs are more than welcome! :)

lidel commented 3 years ago

I think.. "download" is already implemented on download page. @autonome @jessicaschilling I made a quick overwiew of how things look like at https://dev.share.ipfs.io/ atm:

Sharing page:

Here we only copy the "view" link, because that makes the most sense when sharing direct links to things that can be viewed in browser (images, PDFs):

2021-02-04--12-50-27

Download page:

Here we have "view" and "download" actions, so receiver can make a decision if they want to save file or view it:

2021-02-04--12-53-07

autonome commented 3 years ago

I'd love for "view" to be explicit in the design instead of implicit via the filename being a link. Eg, an 👁 button next to the download arrow button, or something like that.

On Thu, Feb 4, 2021 at 6:58 AM Marcin Rataj notifications@github.com wrote:

I think.. "download" is already implemented on download page. @jessicaschilling https://github.com/jessicaschilling I made a quick overwiew of how things look like at https://dev.share.ipfs.io/ atm: Sharing page:

Here we only copy the "view" link, because that makes the most sense when sharing direct links to things that can be viewed in browser (images, PDFs):

[image: 2021-02-04--12-50-27] https://user-images.githubusercontent.com/157609/106888971-9d737480-66e7-11eb-9ec9-6df9b481ce0c.png

Download page:

Here we have "view" and "download" actions, so receiver can make a decision if they want to save file or view it:

[image: 2021-02-04--12-53-07] https://user-images.githubusercontent.com/157609/106889171-f0e5c280-66e7-11eb-8ef2-628a335f4675.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ipfs-shipyard/ipfs-share-files/issues/105#issuecomment-773254555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMHN37OIEZWUA6AQA7TOLS5KDYDANCNFSM4XB44REQ .

jessicaschilling commented 3 years ago

Agree it's less than ideal. MUCH better than it was a week ago but will see if we can improve within the boundaries of the hack week - else will open a new issue to reduce confusion.