search

ipfs-shipyard / ipfs-share-files

Share files via IPFS
https://share.ipfs.io
MIT License
145 stars 29 forks source link

feat: branded SVG QR code #119

Closed lidel closed 3 years ago

lidel commented 3 years ago

This PR tweaks the way QR code is generated and replaces <canvas> with <svg> which looks sharper (at least on my machine)

It also adds a bit of branding, so it looks more native to the app (works due to error-correction built into QR codes) (ok to revert this change – up for your consideration :see_no_evil: )

QR code playground: https://zpao.github.io/qrcode.react/ URL of the icon: https://share.ipfs.io/favicon-32x32.png

Before After
Screenshot_2021-02-05 IPFS Share Share Files Screenshot_2021-02-05 IPFS Share Share Files(1)

(click to compare 1:1)

lidel commented 3 years ago

We need to double-check if error-correction works on skewed screens tho :sweat_smile: