Closed jessicaschilling closed 3 years ago
@lidel @terichadbourne @rafaelramalho19 - this is still WIP but wanted to let y'all know my current status as of EOD Monday. Thanks!
Huge :+1: for copying direct links to specific files
I imagine the remaining work is to figure out if copy action for each file (red arrow) either needs different color or be an icon to differentiate it from the global Copy action (green arrow). Right now it is a bit unclear, there is no "default action":
suggestion: direct copied links should point at specific CID, so http://dweb.link/ipfs/{cid}?filename={name}
– this way each copied direct link is independent of the root folder and other files, making it more useful for ad-hoc sharing.
@lidel I think the most recent set of commits takes care of what you mention in https://github.com/ipfs-shipyard/ipfs-share-files/pull/89#issuecomment-771862732 - but can you please have a review? Thank you.
In this PR
Closes https://github.com/ipfs-shipyard/ipfs-share-files/issues/59 by adding individual "copy" links to files listed in the "add files" context
Closes https://github.com/ipfs-shipyard/ipfs-share-files/issues/94 by switching to
dweb.link
in endpointsAlso the following cosmetic and IA improvements:
To do
In "add" context:
In "download" context:
- [ ] Add big “Get files” header<- decided against this as it'll be redundant once we make changes in https://github.com/ipfs-shipyard/ipfs-share-files/issues/85