Closed SgtPooki closed 2 years ago
with https://github.com/ipfs-shipyard/ipfs-thing-2022/pull/137/commits/eccb6d936067dde5b7607179f82f0d059c9976df, deep-links now look like:
http://localhost:3000/schedule/#IPFS-þing-Opening http://localhost:3000/schedule/#Hack-Cowork-Discuss http://localhost:3000/schedule/#Unconf-and-Miscellaneous-Sessions http://localhost:3000/schedule/#IPFS-Implementations http://localhost:3000/schedule/#Content-Routing-1-Performance http://localhost:3000/schedule/#Content-Routing-2-Privacy http://localhost:3000/schedule/#Data-and-IPFS-Models http://localhost:3000/schedule/#Data-And-IPFS-Transfer http://localhost:3000/schedule/#Project-Community http://localhost:3000/schedule/#Scalable-Virtual-Worlds http://localhost:3000/schedule/#Connecting-IPFS http://localhost:3000/schedule/#Data-and-IPFS-Unconf http://localhost:3000/schedule/#Browsers-and-The-Web-Platform http://localhost:3000/schedule/#IPFS-WASM http://localhost:3000/schedule/#Roadmapping-Next-Steps-out-of-the-IPFS-þing http://localhost:3000/schedule/#IPFS-þing-Closing http://localhost:3000/schedule/#Building-Apps-on-IPFS http://localhost:3000/schedule/#Aqua-and-IPFS http://localhost:3000/schedule/#Measuring-IPFS http://localhost:3000/schedule/#Choose-Your-Icelandic-Adventure http://localhost:3000/schedule/#outing17 http://localhost:3000/schedule/#Welcome-Dinner http://localhost:3000/schedule/#Dinner http://localhost:3000/schedule/#Whale-Museum-Dinner http://localhost:3000/schedule/#z-dinner14 http://localhost:3000/schedule/#z-dinner15 http://localhost:3000/schedule/#z-dinner16 http://localhost:3000/schedule/#Sendoff-Dinner
1. Modals are deeplinked by
encodeURIComponent(event.name)
with a fallback toencodeURIComponent(event.fileName)
where names are duplicate2. Modal open/close adds to window history (going forward/back in browser re-opens/closes modals)
If we don't want 2, let me know, I would just need to revert
'feat: modal open/close uses window.history'
fixes #125