search

ipfs-shipyard / java-ipfs-http-client

A Java implementation of the HTTP IPFS API
MIT License
538 stars 243 forks source link

Use the fresh versions of dependencies #165

Closed odisseus closed 4 years ago

odisseus commented 4 years ago

It turned out that the issues with this set of projects run much deeper than a simple method rename. I decided to solve them bottom up, because I need an up-to-date IPFS interface for the project I'm working at, and i don't feel like linking the entirety of Peergos just for that purpose. Eventually I will get to fix this particular problem as well.

odisseus commented 4 years ago

If by "method names changed" you mean the java.lang.NoSuchMethodError thrown by many test cases, then what's actually changed is the signature of Multihash.deserialize. The latest version of java-cid still expects the old signature, and this causes the errors. They should go away if https://github.com/ipld/java-cid/pull/13 gets merged.

autonome commented 4 years ago

Hi @odisseus are you still working on this or can I have others pick it up? Or is it blocked?

odisseus commented 4 years ago

I stopped working on my pull requests to this library and its dependencies, because I'm not sure my work has any chance to get into the master branch. I believe this particular set of changes can be merged right away; however, it will solve just some of the problems, not all of them.

In particular, the libraries java-multihash and java-cid need to be updated to use a recent commit of java-multibase (ad627a0872 or later), because that commit fixes a critical bug which is inherited by all the dependent libraries. After that's done, the dependency versions in this POM file will have to be updated again.

lidel commented 4 years ago

@odisseus fyi there are open bounties for fixing java-ipfs-http-client library now (https://github.com/ipfs-shipyard/java-ipfs-http-client/issues/157#issuecomment-665278162) and we definitely are up for accepting fixes.

If you want to invest time and claim the bounty, please comment in https://github.com/ipfs-shipyard/java-ipfs-http-client/issues/157#issuecomment-665278162 and provide us with list of all PRs that you are blocked on (Java libs are not actively maintained, but me and @autonome can do some poking/spelunking to unblock you)

lidel commented 4 years ago

Superseded by https://github.com/ipfs-shipyard/java-ipfs-http-client/pull/170