search

ipfs-shipyard / net-ipfs-http-client

InterPlanetary File System client for .Net (C#, VB, F# ...)
MIT License
35 stars 13 forks source link

MfsApi implementation of IMfsApi for making calls to /files endpoints #16

Closed Derrick- closed 1 year ago

Derrick- commented 1 year ago

Implements IMfsApi for interacting with MFS via the Core API. This includes all endpoints under /api/v0/files/.

Tested against ipfs version 0.9.0

Requires: https://github.com/ipfs-shipyard/net-ipfs-core/pull/13

Related: https://github.com/ipfs-shipyard/net-ipfs-http-client/issues/14 https://github.com/ipfs-shipyard/net-ipfs-core/issues/11

Derrick- commented 1 year ago

There is a bug in this PR. ListAsync FileSystemNode results do not include the active IpfsClient field. Will fix.

Derrick- commented 1 year ago

@Arlodotexe if there's anything I can do to help the review process on this, or if you are uncomfortable with the way it's implemented please let me know. I'm interested in knocking out some other issues, but waiting on the outcome this one before proceeding

Arlodotexe commented 1 year ago

@Arlodotexe if there's anything I can do to help the review process on this, or if you are uncomfortable with the way it's implemented please let me know. I'm interested in knocking out some other issues, but waiting on the outcome this one before proceeding

Hey @Derrick-, sorry for the delay. I've been caught up in many other projects, but I'm happy to help you keep this moving. let's start by getting your prerequisite PR done and published to nuget -> https://github.com/ipfs-shipyard/net-ipfs-core/pull/13

Arlodotexe commented 1 year ago

@Derrick- IMfsApi was published in IpfsShipyard.Ipfs.Core 0.0.2. You should be able to complete this PR now.

Derrick- commented 1 year ago

@Derrick- IMfsApi was published in IpfsShipyard.Ipfs.Core 0.0.2. You should be able to complete this PR now.

Thanks. I don't have permission to merge in this repo though, you will need to approve and merge please.

Arlodotexe commented 1 year ago

@Derrick- IMfsApi was published in IpfsShipyard.Ipfs.Core 0.0.2. You should be able to complete this PR now.

Thanks. I don't have permission to merge in this repo though, you will need to approve and merge please.

The build errors need to be fixed first. Should just be updating the net-ipfs-core package at this point.