search

ipfs-shipyard / pinning-service-compliance

This repo checks the compliance of IPFS Pinning Services against the pinning spec
https://ipfs-shipyard.github.io/pinning-service-compliance/
Other
14 stars 10 forks source link

fix: matchPin should confirm that a pin is in the response #116

Closed SgtPooki closed 2 years ago

SgtPooki commented 2 years ago

Some pinning service providers were passing this expectation by simply returning a successful response, even though they weren't actually returning the expected Pin, and we weren't confirming that pin was received either.

With this change, if no Pin is returned, they will fail the expectation.

see https://github.com/ipfs-shipyard/pinning-service-compliance/blob/d3b4334971faf4488d53025dd3714cc5bc541842/nft.storage.md\?plain\=1\#L1253-L1322

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: