ipfs-shipyard / pinning-service-compliance

This repo checks the compliance of IPFS Pinning Services against the pinning spec
https://ipfs-shipyard.github.io/pinning-service-compliance/
Other
14 stars 10 forks source link

Add Filebase to the PSA compliance checker #180

Closed acejam closed 2 years ago

acejam commented 2 years ago

Hi there,

We would like to add Filebase to the IPFS PSA compliance checker. The following SECRETS can be used:

SgtPooki commented 2 years ago

Secrets added. You should have permissions now @hacdias

hacdias commented 2 years ago

@acejam can you please rebase / merge with main to get all upstream fixes and updates?

acejam commented 2 years ago

@hacdias Done

hacdias commented 2 years ago

@SgtPooki I'm almost sure the failing tests are because the PRs don't have access to the secrets, right? How do we go in situations like this?

SgtPooki commented 2 years ago

I kicked off the action manually for a new branch I created from this PR filebase-addition: https://github.com/ipfs-shipyard/pinning-service-compliance/actions/runs/2950538940


edit: it succeeded. merging

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

acejam commented 2 years ago

@SgtPooki Thanks for merging! It looks like https://github.com/ipfs-shipyard/pinning-service-compliance/tree/gh-pages is still missing Filebase reports. Did I miss something in this PR?

SgtPooki commented 2 years ago

@acejam It's showing properly at https://ipfs-shipyard.github.io/pinning-service-compliance/api.filebase.io.html

acejam commented 2 years ago

@SgtPooki Yes, it is now, thanks to ff39295f0a08494758f81a82065e9e232a727284 👍