search

ipfs-shipyard / pinning-service-compliance

This repo checks the compliance of IPFS Pinning Services against the pinning spec
https://ipfs-shipyard.github.io/pinning-service-compliance/
Other
13 stars 10 forks source link

Check requestids rather than cids for pagination #247

Closed flea89 closed 1 year ago

flea89 commented 1 year ago

Problem

The pagination check The next page of pins doesn't contain any of previous pages pins relies on counting unique cids to assert if a request appears on 2 different pages. However, the spec allows for multiple Pin Requests to target the same cid, so the check might fail, if 2 requests with the same id exists, despite the pagination actually working as expected.

The fix

Instead of counting unique cids we should count unique requestids

flea89 commented 1 year ago

@lidel / @SgtPooki let me know if this makes sense and if you need me to change anything. Thanks

SgtPooki commented 1 year ago

Yea that makes sense, thanks for this @flea89

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: