Pinning Service Compliance failures: Estuary

SgtPooki commented 2 years ago

This is a tracking issue for all compliance check failures for the Pinning Service Estuary. Notes & discussions will be in the comment thread, tracking issues for specific failures will be in the below checklist:

Compliance failures

[x] #101
[x] #100
[x] #99
[x] #98
[x] #97
[x] #96
[x] #95
[x] #94

SgtPooki commented 2 years ago

All failures found via script in browser:

const allLines = $$('.js-code-nav-container tr td:nth-child(2)')

const failureLines = allLines.filter((line) => /❌/gi.test(line.innerText))

failureLines.forEach((line) => { console.log(line.innerText) })

ran against page https://github.com/ipfs-shipyard/pinning-service-compliance/blob/d3b4334971faf4488d53025dd3714cc5bc541842/api.estuary.tech.md

❌ Pins post of CID 'baeaaadjrgaysyojyg4ytimrvgq3a' ❌ Can create and then delete a new pin ❌ List pin objects (GET /pins) in all states ❌ Can create and replace a pin's CID ❌ Pagination: Get all pins, create new pins (optional), get first and second pages ❌ Can delete all pins

Pins post of CID 'baeaaadjrgaysyojyg4ytimrvgq3a' - ❌ FAILED

❌ Response object matches api spec schema (failure)

The newly created pin can be immediately deleted - ❌ FAILED

❌ Response code is 202: The Pin was deleted successfully (failure)

Can create and then delete a new pin - ❌ FAILED

❌ Response code is 200 (failure) ❌ Response code is 202: The Pin was deleted successfully (failure)

List pin objects (GET /pins) in all states - ❌ FAILED

❌ Response object matches api spec schema (failure)

Get original pin via requestid - ❌ FAILED

❌ Response code is 404: Original Pin's requestid cannot be found (failure)

Pin's with requestid '31407093' can have cid 'baeaaadjrga2symrsgy2dkmjsgq2q' replaced with 'baeaaadjrga3cymjzgezdinzxheza' - ❌ FAILED

❌ Response code is 404: Original Pin's requestid cannot be found (failure)

Can create and replace a pin's CID - ❌ FAILED

❌ Response code is 404: Original Pin's requestid cannot be found (failure)

Pagination: First page of pins - ❌ FAILED

❌ Count is greater than the number of pins returned (failure) ❌ Number of pins returned defaults to 10 (failure)

Pagination: Get all pins, create new pins (optional), get first and second pages - ❌ FAILED

❌ Count is greater than the number of pins returned (failure) ❌ Number of pins returned defaults to 10 (failure)