search

ipfs-shipyard / py-ipfs-http-client

A python client library for the IPFS API
MIT License
682 stars 201 forks source link

Replace pytest_ordering with pytest_order #286

Closed Luflosi closed 3 years ago

Luflosi commented 3 years ago

pytest_ordering seems unmaintained as it hasn't been updated in two years: https://github.com/ftobia/pytest-ordering. It is also broken, at least in Nixpkgs: https://github.com/NixOS/nixpkgs/pull/122264. pytest_order is a maintained and working fork. I added a similar patch to Nixpkgs a while ago to make it work there: https://github.com/NixOS/nixpkgs/blob/6965eef223f491cc1d9289ce972d8ab6811a2d28/pkgs/development/python-modules/ipfshttpclient/default.nix#L59-L63. It would be nice to get rid of this patch for a future version. I bumped the version in tox.ini a little since version 0.6 does not appear in https://pypi.org/project/pytest-order/#history.

I'm not sure if the line with markers = in tox.ini is still correct with this change, please check.

ntninja commented 3 years ago

Thanks! The marker was indeed only used to work around pytest-orderings failure to register its own markers. Simply hadn't checked for alternatives to this plugin in a long while as it continued working and this workaround was very minimal.

c0llab0rat0r commented 3 years ago

Thanks for this library cleanup.