search

ipfs-shipyard / py-ipfs-http-client

A python client library for the IPFS API
MIT License
678 stars 199 forks source link

add optional arguments to add_str() #287

Closed ftyers closed 3 years ago

ftyers commented 3 years ago

Responding as per request on Matrix. I've added the optional arguments I think are relevant. If this looks good, I'm happy to add the same processing for add_json and add_bytes.

c0llab0rat0r commented 3 years ago

How were these changes tested?

There's some basic errors in the build failures:

https://travis-ci.com/github/ipfs-shipyard/py-ipfs-http-client/jobs/520226458

NameError: name 'nocopy' is not defined

Also, add some new pytest tests to exercise the new parameters and behavior.

ftyers commented 3 years ago

How were these changes tested?

There's some basic errors in the build failures:

https://travis-ci.com/github/ipfs-shipyard/py-ipfs-http-client/jobs/520226458

NameError: name 'nocopy' is not defined

Also, add some new pytest tests to exercise the new parameters and behavior.

They weren't tested.

ntninja commented 3 years ago

@ftyers: If you really want to stop working on this please do tell and we'll probably complete this eventually. (No pressure or anything, I just feel there has been some kind of bad social interaction here, so I don't want you to quit for the wrong reasons.)

ftyers commented 3 years ago

@ntninja I think I don't see the point of contributing if someone already knows how to do it. It seems a lot less efficient going through the motions here than @c0llab0rat0r just doing it themselves as they clearly have a much better idea of Python and the py-ipfs codebase than I do. The reason I opened the PR was to save everyone time, it doesn't feel like we're saving time here. This should be an easy PR and I feel like I'm just wasting everyone's time (mine included).