search

ipfs-shipyard / py-ipfs-http-client

A python client library for the IPFS API
MIT License
682 stars 201 forks source link

chore: pubsub deprecated in ipfs > 0.20.0 #322

Open kasteph opened 1 year ago

kasteph commented 1 year ago

failing test

pubsub command will be deprecated in the next release: rel notes v0.19.0.

We can either remove this entirely or have it be supported for lower versions.

crushr3sist commented 1 year ago

I believe if the actual Kubo IPFS doesn't support the pub-sub command it should be removed from the client as we already have a lot of version-related issues.

It would be more efficient to just remove the functionality.

I'll begin removing the pub-sub code from the client lib to restrict users from causing an error in their code from the usage of pub-sub.

kasteph commented 1 year ago

@Wizock that sounds good to me, I would also rather remove it entirely from the client. Thanks a lot and appreciate you picking this up!

crushr3sist commented 1 year ago

@kasteph I removed the pubsub tests in #326 :))