ipfs-shipyard / service-worker-gateway-2019-poc

[ARCHIVED] 2019 PoC of IPFS gateway fully running on a Service Worker. For modern (2024+) version see https://github.com/ipfs-shipyard/service-worker-gateway

MIT License

61 stars 11 forks source link

preparations for js-ipfs 0.36 #39

Closed olizilla closed 5 years ago

olizilla commented 5 years ago

run the CI tests with ipfs@0.36.0-rc.0

of note, I'm seeing test failures locally on master as well as with the latest ipfs 0.36 rc, so I'm sharing this PR to trigger CI to see if it's just an issue on my machine.

see: https://github.com/ipfs/js-ipfs/issues/2024

olizilla commented 5 years ago

@alanshaw of note the tests are not passing for service-worker-gateway on 0.36.0-rc.0, but they are aren't passing on master with 0.35.0 today either.

olizilla commented 5 years ago

it's just timeouts trying to fetch remote content so far, so may be caused by network conditions beyond the tests.

olizilla commented 5 years ago

@vasco-santos do you have a moment to take a look at why the tests aren't passing?

olizilla commented 5 years ago

~hmm it looks like just bumping the timeouts up is the answer... which isn't great news.~ nope, spoke to soon, bunping it locally to 150000ms didn't help.

vasco-santos commented 5 years ago

@olizilla thanks for putting this together, I will have a look!

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files           4        4           
  Lines          76       76           
=======================================
  Hits           61       61           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13e2c9f...2b17ca2. Read the comment docs.