Closed SgtPooki closed 2 years ago
I guess we could remove the build step(s) from the test command and require all projects to have a "pretest"
script if they need to build before testing?
@achingbrain I think that makes more sense, but we could fix the --build flag too?
:tada: This issue has been resolved in version 37.4.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Describe the bug When running
aegir test
, it always attempts to build, but my project is set up to build prior to running test, so this results in duplicated builds.Additionally, it is passing an invalid flag,
--no-bundle
to my build command for some reasonTo Reproduce Steps to reproduce the behavior:
aegir build
Without passing
--build
flagit should default to false, but it doesn't.
With
--build false
After updating build script to be "aegir build"
Expected behavior
aegir build
if we are not building...--build false
and-b false
and not callaegir build
if set to false.--if-present -- --no-bundle
. If a build is requested, either:npm run build
version.aegir build
.Screenshots N/A
Desktop (please complete the following information):
Additional context This change of functionality is not called out in https://github.com/ipfs/aegir/blob/master/md/migration-to-v37.md