search

ipfs / awesome-ipfs

Community list of awesome projects, apps, tools, pinning services and more related to IPFS.
https://awesome.ipfs.tech/
Creative Commons Zero v1.0 Universal
4.26k stars 530 forks source link

Feature: update danger-js to fail PRs when adding two entries #442

Closed SgtPooki closed 9 months ago

SgtPooki commented 1 year ago

When a contributor creates a PR that adds multiple entries, we typically block on merging the PR and require each entry to be added separately. is this a process we want to keep?

If so, we should update the danger.js file to check that only a single entry is added.

tinytb commented 1 year ago

What's the reason for requiring each entry to be added separately?

SgtPooki commented 1 year ago

What's the reason for requiring each entry to be added separately?

That was the existing pattern. I believe it was intended to keep changes isolated and tie an owner to each added entry. I don’t feel strongly either way but prefer single/isolated additions.

2color commented 9 months ago

I think we can keep it light for now. If it becomes too difficult to review and maintain PRs, we can revisit this.