search

ipfs / benchmarks

Benchmarking for IPFS
MIT License
19 stars 8 forks source link

Js -> Go test fails #241

Open litzenberger opened 5 years ago

litzenberger commented 5 years ago

When customizing the libp2p options in the JS peer, the Go peer can't connect. I can't find the information on syncing the connections.

From the previous issue:

@alanshaw Does the go init use libp2p in the config? I can't find examples how that is configured in go and now I'm getting

{ Error: Command failed: export IPFSPATH=/var/folders/m/_3zzzw7d6dx3gsxlrffsw0s80000gn/T/ipfs0 && ipfs swarm connect /ip4/127.0.0.1/tcp/4012/ipfs/QmSxYJBid9EUdV61T9dUELAsc2FncyQWaSEvm4ztcURiur Error: connect QmSxYJBid9EUdV61T9dUELAsc2FncyQWaSEvm4ztcURiur failure: dial attempt failed: <peer.ID QmfYYr23> --> <peer.ID QmcURiur> dial attempt failed: protocol not supported

when trying to connect js -> go.
litzenberger commented 5 years ago

I have removed the JS->go tests from the runner until this is resolved. To create error run: node extract-js2.go.js

jacobheun commented 5 years ago

I believe the issue is here https://github.com/ipfs/benchmarks/blob/a8549f6c686ea0f517e164d7d565de0b0b3658b5/tests/lib/create-node.js#L55-L57

Currently it's trying to add secio to the stream muxers, which is incorrect, it should be connEncryption. Also, I believe secio might be required right now, so it should probably be added as a default until we have support for other encryptors.

options.libp2p.modules.connEncryption.push(SECIO)