search

ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
205 stars 89 forks source link

provider: prioritize roots and introduce NewPrioritizedProvider #595

Closed hacdias closed 5 months ago

hacdias commented 6 months ago

See https://github.com/ipfs/kubo/pull/10376.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 59.77%. Comparing base (5fc25a4) to head (096cc05).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   59.78%   59.77%   -0.01%     
==========================================
  Files         232      232              
  Lines       28139    28186      +47     
==========================================
+ Hits        16822    16848      +26     
- Misses       9840     9862      +22     
+ Partials     1477     1476       -1
Files Coverage Δ
provider/provider.go 25.74% <40.00%> (+25.74%) :arrow_up:

... and 10 files with indirect coverage changes

hacdias commented 6 months ago

@aschmahmann what do you think? I can replace the map with a bloom filter. That can probably be better memory wise depending on how streams we're using.