search

ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
205 stars 89 forks source link

fix(routing): return 404 when no record is found #601

Closed hacdias closed 5 months ago

hacdias commented 5 months ago

Addresses https://github.com/ipfs/someguy/issues/58.

Sets 404 if the router returns routing.ErrNotFound or if the list of providers is empty.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@a26b503). Click here to learn what that means.

:exclamation: Current head 64094bb differs from pull request most recent head dbe3e8e. Consider uploading reports for the commit dbe3e8e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage        ?   59.47%           
=======================================
  Files           ?      233           
  Lines           ?    28294           
  Branches        ?        0           
=======================================
  Hits            ?    16829           
  Misses          ?     9992           
  Partials        ?     1473
Files Coverage Δ
routing/http/server/server.go 71.85% <57.14%> (ø)