Closed hacdias closed 5 months ago
Attention: Patch coverage is 63.33333%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 59.69%. Comparing base (
eeea414
) to head (8d74823
).
@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 59.88% 59.69% -0.20%
==========================================
Files 238 238
Lines 29868 29883 +15
==========================================
- Hits 17887 17839 -48
- Misses 10375 10425 +50
- Partials 1606 1619 +13
Files | Coverage Δ | |
---|---|---|
bitswap/server/internal/decision/peer_ledger.go | 94.17% <100.00%> (-1.79%) |
:arrow_down: |
bitswap/options.go | 38.09% <0.00%> (-1.91%) |
:arrow_down: |
bitswap/server/internal/decision/engine.go | 91.22% <20.00%> (-0.68%) |
:arrow_down: |
bitswap/server/server.go | 64.63% <0.00%> (-2.43%) |
:arrow_down: |
@lidel I refactored to only have one new option (WithPeerLedger
). I did not add a no-op peer ledger here. I will do this in Rainbow. My idea is that I didn't want to export custom peer ledgers here. We also do not export the default peer ledger, just like it has been done with the score ledger. Just trying to avoid inconsistencies here. If we want to use the no-op peer ledger in other places, we can then bring it to Boxo.
Introduces
WithPeerLedger
, which allows to override the default peer ledger with anything else you want.