ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
205 stars 89 forks source link

fix: delegated routing of legacy RSA peerids #609

Closed lidel closed 4 months ago

lidel commented 4 months ago

This PR continues work from https://github.com/ipfs/boxo/pull/585 which fixed support for ED25519 as BAse58. Here, we add correct support for RSA PeerIDs.

I also added test matrix for all PeerID variants versions to ensure we don't regress.

After this is merged, /routing/v1/peers endpoint will accept all variants of PeerIDs we see in the wild.

Namely:

@hacdias if this looks good, mind bubbling up to Someguy, and making new release, and deploying to https://delegated-ipfs.dev/?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.72%. Comparing base (0f223aa) to head (d5c1c6c).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   59.66%   59.72%   +0.05%     
==========================================
  Files         238      238              
  Lines       29883    29889       +6     
==========================================
+ Hits        17831    17851      +20     
+ Misses      10433    10420      -13     
+ Partials     1619     1618       -1     
Files Coverage Δ
routing/http/server/server.go 72.46% <80.00%> (+0.40%) :arrow_up:

... and 15 files with indirect coverage changes