ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
181 stars 83 forks source link

feat(bitswap/client): add additional tracing #615

Closed aschmahmann closed 3 weeks ago

aschmahmann commented 1 month ago

This is an attempt at adding some more visibility to the Bitswap tracing code path. This overall looks to be a good improvement, but I would expect the shape of the tracing (e.g. spans vs events, granularity and names of spans/events, etc.) to change over time here and don't think we want to commit to documenting each of those changes.

I'm labeling as skip/changelog, but happy to add some info if it makes sense.

Feedback definitely welcome 🙏

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.77%. Comparing base (4f2d250) to head (b1da22c).

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   59.77%   59.77%           
=======================================
  Files         238      238           
  Lines       29943    29979   +36     
=======================================
+ Hits        17898    17920   +22     
- Misses      10429    10439   +10     
- Partials     1616     1620    +4     
Files Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 88.21% <100.00%> (+1.07%) :arrow_up:
bitswap/client/internal/session/session.go 91.15% <100.00%> (+0.09%) :arrow_up:

... and 10 files with indirect coverage changes