ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
205 stars 89 forks source link

feat(routing/none): remove nil router #621

Closed aschmahmann closed 3 months ago

aschmahmann commented 3 months ago

Closes #620

This removes the nil router, if people would prefer something less harsh (e.g. deprecation followed by removal, stubbing followed by deprecation + removal) comment on the issue above

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.53%. Comparing base (aaf9a04) to head (7e1497e).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   59.67%   60.53%   +0.86%     
==========================================
  Files         239      238       -1     
  Lines       29961    29537     -424     
==========================================
+ Hits        17879    17881       +2     
+ Misses      10460    10034     -426     
  Partials     1622     1622              

see 33 files with indirect coverage changes