Closed lidel closed 3 weeks ago
Attention: Patch coverage is 63.57143%
with 51 lines
in your changes missing coverage. Please review.
Project coverage is 59.81%. Comparing base (
980447e
) to head (4eec0e4
).
@@ Coverage Diff @@
## release #622 +/- ##
===========================================
- Coverage 59.83% 59.81% -0.02%
===========================================
Files 239 238 -1
Lines 29961 29984 +23
===========================================
+ Hits 17928 17936 +8
- Misses 10419 10431 +12
- Partials 1614 1617 +3
Files | Coverage Δ | |
---|---|---|
...ernal/providerquerymanager/providerquerymanager.go | 87.45% <100.00%> (-1.35%) |
:arrow_down: |
bitswap/client/internal/session/session.go | 91.15% <100.00%> (+0.09%) |
:arrow_up: |
routing/http/contentrouter/contentrouter.go | 50.56% <63.15%> (+1.42%) |
:arrow_up: |
examples/car-file-fetcher/main.go | 38.88% <38.88%> (ø) |
["main"]
)This PR is targeting release
, which is not any of ["main"].
If you wish to cut a release once this PR is merged, please add the release
label to this PR.
Suggested version: v0.21.0
Changes in go.mod
file(s):
(empty)
gorelease
says:
# diagnostics
go.mod: the following requirements are needed
go.opentelemetry.io/otel/exporters/jaeger@v1.14.0
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon
# summary
Suggested version: v0.20.1
gocompat
says:
Your branch is up to date with 'origin/release'.
This PR is modifying both version.json
and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release
. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.
A draft GitHub Release has been created. It is going to be published when this PR is merged. You can modify its' body to include any release notes you wish to include with the release.
Ok, took some notes in https://github.com/ipfs/boxo/issues/623 on the process, but no blockers, all green.
Shipping and bubbling up to kubo/rainbow/someguy, so we can tag releases of the last two next week.
This is me following the process from https://github.com/ipfs/boxo/blob/main/RELEASE.md#release-process (minus creating issue with the checklist, I'm doing the checklist below).
Initial impression: we could simplify a lot of manual labor by switching to release-please, and doing patch releases if needed by hand, rather than doing everything by hand. We will discuss once this one ships the old way.
release-vX.Y.Z
and push itmaster
as base ifZ == 0
release
as base ifZ > 0
release-vX.Y.Z
release-vX.Y.Z
intorelease
Z > 0
, then cherry-pick the necessary commits frommaster
intorelease-vX.Y.Z
usinggit cherry-pick -x <commit>
go get github.com/ipfs/boxo@<commit_hash>
using the commit hash of therelease-vX.Y.Z
branchgo mod tidy
in repo root and indocs/examples/kubo-as-a-library
release-vX.Y.Z
bumping the version inversion.json
tovX.Y.Z
release
, using "Create a Merge Commit", and do not delete therelease-vX.Y.X
branchvX.Y.Z
in the title and bodyrelease
intomain
release
branch