search

ipfs / boxo

A set of reference libraries for building IPFS applications and implementations in Go.
https://github.com/ipfs/boxo#readme
Other
205 stars 89 forks source link

fix(bitswap): use unique logger name for MessageQueue #632

Closed Wondertan closed 2 months ago

Wondertan commented 3 months ago

bitwap is already taken by the root pkg and there is no way to access the MessageQueue logger

gammazero commented 2 months ago

@lidel I think we should use bitswap/foo as that seems to be the typical convention in other parts of boxo..

I went ahead and made a PR to do that: #637. If that looks good we can use it in place of this.

lidel commented 2 months ago

Sgtm, let's continue in https://github.com/ipfs/boxo/pull/637 Thank you for prompting this cleanup @Wondertan :+1: