Closed jessicaschilling closed 4 years ago
@Stebalien -- do you mind having a look if you have time? Thanks!
Question: What's the situation with dir-index.html vs dir-index-uncat.html? Are we maintaining both of these? If so, would still appreciate a review before duplicating changes to dir-index-uncat.html.
We're trying to, at least. We should add a script that generate dir-index.
@stebalien - thanks! Just duplicated the dir-index.html
changes to dir-index-uncat.html
. Should be good to go.
@jessicaschilling just tested this with go-ipfs 0.5.50-rc3 and looks awesome! :heart:
Mind updating screenshot in README.md
?
I would do it myself but screenshots made on Linux are fugly :sweat:
@lidel Yours to merge: https://github.com/ipfs/dir-index-html/pull/28
Changes to
dir-index.html
only (see question below):Note that this still isn't responsive; fixing that is more involved and is part of https://github.com/ipfs/dir-index-html/issues/24.
Question: What's the situation with
dir-index.html
vsdir-index-uncat.html
? Are we maintaining both of these? If so, would still appreciate a review before duplicating changes todir-index-uncat.html
.Closes #1