ipfs / dir-index-html

Directory listing HTML for go-ipfs gateways
MIT License
38 stars 55 forks source link

HTTP Error 404 for /favicon.ico #35

Closed lidel closed 4 years ago

lidel commented 4 years ago

Directory listings are missing favicon definition, which makes browser to make request for implicit /favicon.ico which always fails.

To illustrate, opening https://bafybeiccfclkdtucu6y4yc5cpr6y3yuinr67svmii46v5cfcrkp47ihehy.ipfs.dweb.link/ produces two requests:

2020-06-21--22-11-52

We could either add a favicon (would have to be inlined as dataurl to work in every context) or supress the request with:

<link rel="shortcut icon"type="image/x-icon" href="data:image/x-icon;,">
jessicaschilling commented 4 years ago

https://github.com/ipfs/dir-index-html/pull/36 should close this. Out for review.