Open RichardLitt opened 7 years ago
@haadcode Which releases do we want on this?
@haadcode I ran into a problem with building orbit, not sure why. I'm still getting the old bug:
inflating: v3.2.0/orbit-3.2.0/test/orbit.test.js
--> making v3.2.0
npm ERR! git fetch -a origin (https://github.com/haadcode/uport-persona-1.git) remote: Repository not found.
npm ERR! git fetch -a origin (https://github.com/haadcode/uport-persona-1.git) fatal: repository 'https://github.com/haadcode/uport-persona-1.git/' not found
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/richard/.nvm/versions/node/v6.4.0/bin/node" "/Users/richard/.nvm/versions/node/v6.4.0/bin/npm" "i"
npm ERR! node v6.4.0
npm ERR! npm v3.10.3
npm ERR! code 128
npm ERR! Command failed: git fetch -a origin
npm ERR! remote: Repository not found.
npm ERR! fatal: repository 'https://github.com/haadcode/uport-persona-1.git/' not found
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR! <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR! /Users/richard/src/ipfs/distributions/dists/orbit/build/v3.2.0/orbit-3.2.0/npm-debug.log
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/richard/.nvm/versions/node/v6.4.0/bin/node" "/Users/richard/.nvm/versions/node/v6.4.0/bin/npm" "run" "dist-all"
npm ERR! node v6.4.0
npm ERR! npm v3.10.3
npm ERR! missing script: dist-all
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR! <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR! /Users/richard/src/ipfs/distributions/dists/orbit/build/v3.2.0/orbit-3.2.0/npm-debug.log
./app-release: line 63: cd: dist: No such file or directory
mv: rename assets to ../../../../../../releases/electron-app/assets: Directory not empty
mv: rename client to ../../../../../../releases/electron-app/client: Directory not empty
mv: rename screenshots to ../../../../../../releases/electron-app/screenshots: Directory not empty
mv: rename scripts to ../../../../../../releases/electron-app/scripts: Directory not empty
mv: rename src to ../../../../../../releases/electron-app/src: Directory not empty
mv: rename test to ../../../../../../releases/electron-app/test: Directory not empty
--> making dist.json
./app-release: line 69: ./mkdist.js: No such file or directory
Is v3.2.0 the most recent version? Or am I missing something? Are the releases up to date?
@RichardLitt it'd be best to report Orbit related bugs in haadcode/orbit. But to answer your question, it seems you're running a very old version of Orbit (https://github.com/haadcode/uport-persona-1.git hasn't been part of Orbit's code base in a long time). Make sure you're on master, you've checkout the latest, have done rm -rf node_modules/
before running the build commands.
Easiest way to make the release builds is to run make
, then make build
and then make dist
(to get .tar.gz packages. See https://github.com/haadcode/orbit/blob/master/Makefile for details. I don't think the make
commands are documented atm, we should do that.
Which releases do we want on this?
If you mean which platforms and archs to support, we currently do 64bit darwin (osx) and linux. I think we could trivially add support for 32bit and arm but we'd need to verify that, so let's start with 64bit builds only. Windows doesn't work at the moment, we'll have to leave that out for now and add it in when we have a windows build.
Btw. we use electron-builder which builds everything automatically, see the supported build options here https://github.com/electron-userland/electron-builder#cli-usage.
@RichardLitt it'd be best to report Orbit related bugs in haadcode/orbit. But to answer your question, it seems you're running a very old version of Orbit (https://github.com/haadcode/uport-persona-1.git hasn't been part of Orbit's code base in a long time). Make sure you're on master, you've checkout the latest, have done rm -rf node_modules/ before running the build commands.
Hmm. I think the issue is that the release hasn't been updated since October. It's not that I'm using an older version of orbit; it's that we're not releasing it properly. So, we need to start bumping the versions if we're going to use dist.ipfs.io, I think.
Pushed an update, using master
. I'm getting two builds: orbit-darwin-x64.tar.gz
and orbit-linux-x64.tar.gz
. Would be good to talk about mkdist.js
- it doesn't work for orbit, probably because I am not using a v*
version number, but I'm wondering what it is supposed to do, anyway. @haadcode Let's chat early tomorrow morning my time. I'll sign on and see if we can work together for a bit.
This is blocked until orbit is up to date in deps and electron build runs again. I know @haadcode is working on it \o/
This issue tracks the relevant steps needed to add Orbit to dist.ipfs.io, specifically referring to code which needs to happen on this branch. See https://github.com/haadcode/orbit/issues/132 for an overarching issue about how to make this happen.
Current steps needed AFAIK: