search

ipfs / gateway-conformance

a vendor-agnostic gateway conformance test suite for implementers of IPFS Gateways to ensure compliance with https://specs.ipfs.tech/http-gateways/
https://specs.ipfs.tech/http-gateways/
Other
14 stars 14 forks source link

bug: forks seems to break download-artifacts #167

Open laurentsenta opened 12 months ago

laurentsenta commented 12 months ago

Code used to download artifacts from other repos: https://github.com/ipfs/gateway-conformance/blob/78aa307ee0b858b5c815775133836832cd8e312a/.github/workflows/deploy-pages.yml#L36-L60

Action failed: https://github.com/ipfs/gateway-conformance/actions/runs/6218823800/job/16875980114

Run dawidd6/action-download-artifact@v2
==> Repository: ipfs/kubo
==> Artifact name: gateway-conformance.json
==> Local path: ./
==> Workflow name: gateway-conformance.yml
==> Workflow conclusion: completed
==> Branch: master
==> (found) Run ID: 62[1](https://github.com/ipfs/gateway-conformance/actions/runs/6218823800/job/16875980114#step:3:1)0849710
==> (found) Run date: 2023-09-[17](https://github.com/ipfs/gateway-conformance/actions/runs/6218823800/job/16875980114#step:3:18)T01:42:28Z
==> (not found) Artifact: gateway-conformance.json
==> Found the following artifacts instead:
Error: no artifacts found

When I open the run_id: https://github.com/ipfs/kubo/actions/runs/6210849710 That looks like the master branch from a fork.

laurentsenta commented 12 months ago

(fixing this now, I'd like to make a demo this evening)

laurentsenta commented 12 months ago

Fix in https://github.com/dawidd6/action-download-artifact/pull/250