Closed whizzzkid closed 10 months ago
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.
@achingbrain Interesting, I only added https://github.com/ipfs/github-mgmt/pull/182/commits/7dd2a9060b01d7f9dacd1d88ea2f5bbe6ca8d8e6 then a sneaky commit shows up as me: https://github.com/ipfs/github-mgmt/pull/182/commits/82363f83968e27c706ed27bb19e0de839cef1723
It's unverified, not me, the bot-overlords assumed my identity and pulled these shenanigans.
Huh, weird - something similar happened in the libp2p/github-mgmt repo the other day.
@galargh @laurentsenta can this be prevented from happening?
I wrote down a longer reply in https://github.com/libp2p/github-mgmt/pull/198/#discussion_r1440325493.
Similarly to that case, here, https://github.com/ipfs/github-mgmt/pull/181 was left unattended for a while.
I filed an issue for commits that are incorrectly associated with real users - https://github.com/ipdxco/github-as-code/issues/110
As for changing the existing behaviour, you could remove the pull_request_target
trigger from https://github.com/ipfs/github-mgmt/blob/master/.github/workflows/fix.yml#L4. Without it, the fix workflow would only get triggered on pushes to the default branch.
I'm about to archive most of the @helia/*
repos as we're merging them into the main monorepo so this should probably be reduced in scope - https://github.com/ipfs/helia/pull/363
@achingbrain so this should still be merged? Or should wait for the monorepo change? IIUC this can go in independent of that change.
I would very much like no further commits to be pushed to the repos that are being merged into the main Helia monorepo.
Alright! @achingbrain I'll merge it once you're ready!
Edit: the merge is blocked on your review. Will merge when unblocked
This should be good to go now!
I ran https://github.com/ipfs/github-mgmt/actions/workflows/sync.yml to pull in the repo archivisation actions into the state of this repository.
@lidel @achingbrain do either of you have merge permissions on this?
Summary
Adding pull request template for all
helia*
projects.Why do you need this?
For the sake of consistency
DRI: myself
Reviewer's Checklist