ipfs / github-mgmt

10 stars 25 forks source link

Remove temporary vesahc admin access #200

Closed Stebalien closed 7 months ago

Stebalien commented 7 months ago

Summary

See the comment, it's after March 31st.

Reviewer's Checklist

github-actions[bot] commented 7 months ago

The following access changes will be introduced as a result of applying the plan:

Access Changes ``` User vesahc: - will have the role in the organization change from admin to member ```
Stebalien commented 7 months ago

@galargh any idea what the test failure is?

github-actions[bot] commented 7 months ago

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs ``` Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # github_membership.this["vesahc"] will be updated in-place ~ resource "github_membership" "this" { id = "ipfs:vesahc" ~ role = "admin" -> "member" # (2 unchanged attributes hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ```
galargh commented 7 months ago

@galargh any idea what the test failure is?

It's because we don't allow removing members from the organization or deleting repositories via GitHub as Code. This is because these two actions are harder to revert.

I moved vesahc to the regular members group of the organization. Would that be OK?

Other than than that, the PR looks good 👍

Stebalien commented 7 months ago

It's because we don't allow removing members from the organization or deleting repositories via GitHub as Code. This is because these two actions are harder to revert.

Ah, I see. Yeah, that makes sense.