welcome[bot]
commented
3 years ago Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:
- "Priority" labels will show how urgent this is for the team.
- "Status" labels will show if this is ready to be worked on, blocked, or in progress.
- "Need" labels will indicate if additional input or analysis is required.
Finally, remember to use https://discuss.ipfs.io if you just need general support.
BigLep
engine_test.go:1073: Peers should be tagged but weren't --- FAIL: TestTaggingUseful (0.05s)
The error happens when i = 1. I print some info before the following line https://github.com/ipfs/go-bitswap/blob/0fa397581ca6197c6c4ca17842719370f6596e95/internal/decision/scoreledger.go#L166 and find at some time,
lastExchangeequalslastShortUpdate, so the update is missedI think
if !l.lastExchange.Before(lastShortUpdate)would be better?