ipfs / go-bitswap

The golang implementation of the bitswap protocol
MIT License
216 stars 112 forks source link

fix: TestTaggingUseful failed to pass #473

Closed zeigo closed 3 years ago

zeigo commented 3 years ago

fix for https://github.com/ipfs/go-bitswap/issues/472

welcome[bot] commented 3 years ago

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

BigLep commented 3 years ago

@dirkmc : can you review to see if this can be merged or not?

dirkmc commented 3 years ago

@zeigo I don't think this change makes sense - it looks like it could cause us to double-count the score of some peers

BigLep commented 3 years ago

Closing for now since maintainer input hasn't been incorporated. Feel free to reopen if/when it does. Thanks!